Skip to content

Conversation

@emilioalvap
Copy link
Contributor

Summary

Add maintenance windows options to synthetics docs. Relates to elastic/synthetics#1103.

Generative AI disclosure

  1. Did you use a generative AI (GenAI) tool to assist in creating this contribution?
  • Yes
  • No

@github-actions
Copy link

✅ Vale Linting Results

No issues found on modified lines!

@github-actions
Copy link

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit otherwise LGTM.


`--maintenance-windows Array<string>`
: A list of maintenance window IDs used to associate every monitor with one or more [maintenance windows](/explore-analyze/alerts-cases/alerts/maintenance-windows.md). This argument accepts a variable number of values as shown in the example.
Example: `--maintenance-windows "maintenance-window-ID-1" "maintenance-window-ID-2`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Example: `--maintenance-windows "maintenance-window-ID-1" "maintenance-window-ID-2`
Example: `--maintenance-windows "maintenance-window-ID-1" "maintenance-window-ID-2`

Just adding a line here to match the formatting of the other example(s) in the doc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's annoying that the GH suggestion UI makes it look like you also increased the indent size. I had to view the raw MD to see that you didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants